Skip to content

chore: fix flaky smokes #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tatomyr merged 6 commits into from
Jan 2, 2026
Merged

chore: fix flaky smokes #2486

tatomyr merged 6 commits into from
Jan 2, 2026
+11 −0

Conversation

@tatomyr
Copy link
Collaborator

@tatomyr tatomyr commented Dec 31, 2025 •
edited
Loading

What/Why/How?

  • Fixed flaky smokes (win+yarn)
  • Updated perf benchmark setup

Check yourself

  • Code changed? - Tested with Redoc/Realm/Reunite (internal)
  • All new/updated code is covered by tests
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3b8c42d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.58% (🎯 78%) 6190 / 7877
🔵 Statements 78% (🎯 78%) 6396 / 8199
🔵 Functions 81.95% (🎯 81%) 1263 / 1541
🔵 Branches 70.41% (🎯 70%) 4246 / 6030
File CoverageNo changed files found.
Generated in workflow #8268 for commit 3b8c42d by the Vitest Coverage Report Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025 •
edited
Loading

CLI Version Mean Time ± Std Dev (s) Relative Performance (Lower is Faster)
cli-latest 3.316s ± 0.039s ▓ 1.00x (Fastest)
cli-next 3.320s ± 0.015s ▓ 1.00x

@tatomyr tatomyr force-pushed the tests/fix-flaky-smokes branch from 11f25e3 to 481248f Compare December 31, 2025 15:26
tatomyr
tatomyr commented Dec 31, 2025
View reviewed changes
packages/cli/package.json
"@redocly/openapi-core": "2.14.2",
"@redocly/respect-core": "2.14.2",
"abort-controller": "^3.0.0",
"ajv-formats": "^3.0.1",
Copy link
Collaborator Author

@tatomyr tatomyr Dec 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason yarn sometimes cannot resolve transitive dependencies on Win. Added it here explicitly (should change nothing as it imports openapi-core which has ajv-formats as a dependency itself).

@tatomyr tatomyr marked this pull request as ready for review December 31, 2025 15:58
@tatomyr tatomyr requested a review from a team as a code owner December 31, 2025 15:58
@tatomyr tatomyr force-pushed the tests/fix-flaky-smokes branch from 481248f to 392d2b6 Compare January 2, 2026 08:33
@tatomyr tatomyr merged commit 3b5f524 into main Jan 2, 2026
41 checks passed
@tatomyr tatomyr deleted the tests/fix-flaky-smokes branch January 2, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadyvas vadyvas vadyvas approved these changes

Assignees

No one assigned

Labels

no changeset needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tatomyr @vadyvas